fix(runtime): avoid dropping local queue on different threads#513
Conversation
Berrysoft
added
bug
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where task queues could be dropped on different threads than where they were created, which could cause panics due to SendWrapper's drop guard. The fix introduces a WeakTaskQueue pattern to ensure the actual TaskQueue is always dropped on its creator thread.
- Wraps
TaskQueuefields inArcto enable weak references - Introduces
WeakTaskQueuewith weak references and thread tracking for safe cross-thread handling - Refactors task scheduling to use
WeakTaskQueuein closures that may be dropped on different threads
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| compio-runtime/src/runtime/scheduler/send_wrapper.rs | Adds #[allow(dead_code)] to unused get() method |
| compio-runtime/src/runtime/scheduler/mod.rs | Refactors task queue architecture to prevent cross-thread drops by introducing WeakTaskQueue and Arc-wrapping queue components |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I’ve opened a PR that uses raw pointers, so we don’t need extra tricks to work around the limitations of |
|
Also @Paraworker to review if you're free. |
|
I think I'm going to merge this one. It'll be complex to reimplement a better |
Closes #512
Not sure if it is OK.
cc: @Paraworker